1065441 - [UX] Review of Loop UI

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

The engineering work on Loop has been going on without any design review so far. It's time to do a review of what is currently in Nightly.

Comment 1

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: Loop Review V1

Here's what I could catch.

Comment 2

[:Paolo Amadini]

(In reply to Philipp Sackl [:phlsa] from comment #1)
> Here's what I could catch.

Hey Philipp, any chance you could look at the Contacts UI that just landed in fx-team? (It's not in mozilla-central yet.) There are probably adjustments to do there as well.

For now the video call button does nothing, and audio/video call context menu items are not active, but the rest should work as expected.

Comment 3

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to :Paolo Amadini from comment #2)
> (In reply to Philipp Sackl [:phlsa] from comment #1)
> > Here's what I could catch.
> 
> Hey Philipp, any chance you could look at the Contacts UI that just landed
> in fx-team? (It's not in mozilla-central yet.) There are probably
> adjustments to do there as well.
> 
> For now the video call button does nothing, and audio/video call context
> menu items are not active, but the rest should work as expected.

Generally yes, but that should probably happen in a different bug.
Also, is there a place where I can download a build of fx-team, or do I have to build that myself?

Comment 4

[:Paolo Amadini]

(In reply to Philipp Sackl [:phlsa] from comment #3)
> Also, is there a place where I can download a build of fx-team, or do I have
> to build that myself?

Generally, you can go to <https://tbpl.mozilla.org/?tree=Fx-Team>, select a green "B" letter on the right for the platform you're interested into, click the small "go to build directory" link in the lower left corner, and then select the right file from the list. Intuitive!

Comment 5

[Romain Testard [:RT]]

Hi,

Is the review done with Mac only?
Do you consider the following bugs appropriate to report as part of this review?
Fonts on windows : https://bugzilla.mozilla.org/show_bug.cgi?id=1065537
Blurry logo on windows: https://bugzilla.mozilla.org/show_bug.cgi?id=1074284
Blurry client icons: https://bugzilla.mozilla.org/show_bug.cgi?id=1068593
Blurry camera icon: https://bugzilla.mozilla.org/show_bug.cgi?id=1060590
Blurry accept icon: https://bugzilla.mozilla.org/show_bug.cgi?id=1068594

Some more comments:
* The "Cancel and block" button is too small (similar to number 5 with "Voice conversation") - attached screenshot
* The feedback form displays a vertical scroll bar - attached screenshot

Comment 6

[Romain Testard [:RT]]

Attachment: feedback form vertical scroll.png

Vertical scroll bar on feedback form (Windows 8)

Comment 7

[Romain Testard [:RT]]

Attachment: Cancel and block.png

Cancel and block button too small

Comment 8

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to Romain Testard [:RT] from comment #5)
> Hi,
> 
> Is the review done with Mac only?
> Do you consider the following bugs appropriate to report as part of this
> review?
> Fonts on windows : https://bugzilla.mozilla.org/show_bug.cgi?id=1065537
> Blurry logo on windows: https://bugzilla.mozilla.org/show_bug.cgi?id=1074284
> Blurry client icons: https://bugzilla.mozilla.org/show_bug.cgi?id=1068593
> Blurry camera icon: https://bugzilla.mozilla.org/show_bug.cgi?id=1060590
> Blurry accept icon: https://bugzilla.mozilla.org/show_bug.cgi?id=1068594
> 
> Some more comments:
> * The "Cancel and block" button is too small (similar to number 5 with
> "Voice conversation") - attached screenshot
> * The feedback form displays a vertical scroll bar - attached screenshot

I did test on Windows (8) and Linux as well (see #9 in the review comp).
The bugs you've listed all look very valid to me. Some are already included in the comp as well. I will update it to also show the bug numbers and add the ones missing.

Comment 9

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: Updated review

Updated comp including the issues raised by Romain as well as some bug numbers.

Comment 10

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Got a verbal r+ from Darrin the other day, so I'm marking this as fixed.